'yield' is a reserved word in strict mode

[jamietre]

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Reserved_Words

The immediate consequence of this to me is that the minifier used by ASP.NET MVC4's script optimizer fails. Consider replacing the method name with a non-reserved word.

[briancavalier]

Hey @jamietre, reserved words may legally be used as object property names in ES5, so we probably won't change the name yield. However, perhaps what we should do is to quote it when using it internally in when.js so that tools such as .NET's, that don't yet understand ES5 rules, don't break.

How does that sound?

[jamietre]

Sounds great! Thanks.

[briancavalier]

Cool, just to make sure: Your tools will handle: promise['yield'](x), and they won't handle promise.yield(x)?

I did a quick check of the codebase and there are only 2 usages of .yield(x): one in when.js and one in when/unfold/list.js. So, we should be able to change those both to ['yield'](x) in a 2.1.1 hotfix.

[jamietre]

Yes - I had already made the change locally it works fine with exactly that change.

[briancavalier]

Thanks! I'll try to get that out within the next day.

[briancavalier]

Just pushed a fix to the hotfix-157 branch. Let me know if that looks good to you.

[jamietre]

Perfect! Thank you so much!

[briancavalier]

Pushed to master, tagged, and published.