Cancelable deferreds should resolve normally #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A resolved cancelable deferred should provide the resolved value to its callbacks. It previously always returned null.
|
Just to record the final outcome: After investigating this, it turned out to be a bug in the when.js core rather than in when/cancelable. There was a specific case where passing null as the callback could cause the resolution value to be clobbered with null. It didn't affect all promises, or the errback or progressback. |
briancavalier
added a commit
that referenced
this pull request
Mar 11, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A resolved cancelable deferred should provide the resolved value to its
callbacks. It previously always returned null.