Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions between questions Chrome/Android #582

Closed
stianr opened this issue Dec 15, 2017 · 17 comments
Closed

Transitions between questions Chrome/Android #582

stianr opened this issue Dec 15, 2017 · 17 comments

Comments

@stianr
Copy link

stianr commented Dec 15, 2017

At last I seem to have identified a replicable version of the transitions problem that we saw earlier in the term. It seems to occur specifically on chrome for Android. I've replicated it on my own Galaxy S7 after a student showed it on her J5. If you try completing a live quiz, the transitions between questions are incredibly slow, and the screen is blank for much of the time. It can take 30 seconds for a question to appear, and seems to get worse as the quiz progresses (though that may not be a consistent effect).

@stianr stianr added the bug label Dec 15, 2017
@stianr stianr changed the title Transitions between questions Transitions between questions Chrome/Android Dec 18, 2017
@stianr stianr added this to the Next sprints milestone Dec 18, 2017
@iteles
Copy link
Collaborator

iteles commented Jan 17, 2018

We have tried to replicate this unsuccessfully on a Nexus 5X but have dug up another older Android phone to try this.

It could also be a function of the number of questions in the quiz (our test quiz only had 3), the number of students taking it at once or the network itself.

@stianr
Copy link
Author

stianr commented Jan 17, 2018

Just tried again: The problem didn't occur with a short, simple quiz (2 questions, minimal text), but reappeared when running a longer quiz, so hopefully you'll be able to see it on your devices.

To try to replicate the issue, import this quiz into Quodl as lecturer: BJ4s1HZGf and then run as usual, using Chrome on Android as a student to respond. I found that by Q3 transitions were getting unworkably long.

(Fwiw, I used a Galaxy S7 with Chrome 63.0.3239.111 / Android 7.0, so I don't think it's down to processor speed or similar. )

@stianr
Copy link
Author

stianr commented Jan 17, 2018

Okay, to isolate the cause further, I tried two separate quizzes. One had 8 two-option short questions (you can import with this code: Bkig5-TVz); the other had three extremely wordy questions (rkT_9W64G). The first ran fine, the second started stuttering at the first question. It even struggled when I reduced the number of options to 2 (but each option contained a fair amount of text). So it looks like it's the amount of text in a question and its options that is causing the problem.

Again, no problem running this on the same phone with FireFox.

@iteles
Copy link
Collaborator

iteles commented Jan 18, 2018

Thanks for that @stianr, excellent detective work 🔎

@dwylbot
Copy link

dwylbot bot commented Jan 22, 2018

@sohilpandya the in-progress label has been added to this issue without an Assignee.
dwylbot has automatically assigned you.

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot
Copy link

dwylbot bot commented Jan 22, 2018

@sohilpandya the in-progress label has been added to this issue without a time estimation.
Please add a time estimation to this issue before applying the in-progress label.

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@sohilpandya
Copy link
Contributor

Hey, just an update, we have some transitions which look to be the cause of this, we've removed them on the local version and the lag is not there anymore.

Still work in progress, will try out other method for animation and report back here.

@sohilpandya
Copy link
Contributor

Looks like there seems to be an animation issue on chrome mobile. We've tried to use other Greensock methods and CSS transform both perform really well on iPhone (chrome & safari) and desktop but not on Android running 7.0.1 with chrome mobile(Sony Xperia).

We will stop the spike and move onto other tasks, will research a little further and see if we can solve this, alternatively, we can just remove the animations between questions. That would be the last resort if we are unable to find a solution.

@stianr
Copy link
Author

stianr commented Jan 22, 2018

Thanks @sohilpandya. If it's possible to easily remove the animations just from Chrome (or better still just from Chrome mobile), but retain them for other browsers, then I'd suggest doing that and moving on to other issues. If it means losing the animations for all browsers, it's probably worth looking at further.

@stianr
Copy link
Author

stianr commented Jan 26, 2018

This isn't working for me - transitions still very slow with wordy questions. Screen recording to illustrate here:

https://www.dropbox.com/s/noei2xk6vux6cul/20180126_111917.mp4

@stianr
Copy link
Author

stianr commented Jan 26, 2018

You could see if it replicates using 'Testing Stian - Wordy' on lecturer account or importing S1W2x5dBf

@sohilpandya
Copy link
Contributor

Hi @stianr,

Apologies it looks like the changes aren't reflected on the staging site just yet. Will update you as soon as they are pushed and ready for you to test.

@stianr
Copy link
Author

stianr commented Jan 26, 2018

Ah right, will hang on for testing these developments...

@sohilpandya
Copy link
Contributor

@stianr, this is ready for you to test again.

I'd recommend that you wait around 10/25 seconds on the holding screen before proceeding with starting the quiz, as you would when running it live to wait for students.

@stianr
Copy link
Author

stianr commented Jan 26, 2018

@sohilpandya it's still looking the same for me, with slow transitions. Do you want me to share a screen recording?

@sohilpandya
Copy link
Contributor

Hmm, that is interesting. I've trialled it on the chrome browser with a Sony Xperia and a Google Nexus 5 phone multiple times and the transitions seem to be very smooth.

Screen recording won't really help as we won't be able to debug it.

@stianr
Copy link
Author

stianr commented Jan 28, 2018

I've just tested this again now, and it seems to be working, with smooth transitions. I wonder if it wasn't fully pushed through to the staging site, or was partly cached somewhere when I tried to run it. Anyway I think that's the problem fixed - thanks @sohilpandya!

@stianr stianr closed this as completed Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants