Skip to content

Commit

Permalink
fix: tweak output alignment
Browse files Browse the repository at this point in the history
The padding on the bottom element pulled the text out of line.

Adding the check mark makes the annotation a little clearer that it's all OK.
  • Loading branch information
jamestelfer committed Mar 15, 2024
1 parent 72064de commit 9e0a5ff
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions src/report/annotation.gohtml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ be wrapped in <p> tag by the Markdown renderer in Buildkite.
{{ end }}
</dl>
{{ else }}
<p>No vulnerabilities reported.</p>
<p>No vulnerabilities reported.</p>
{{ end }}
{{ if .FindingSummary.FailedPlatforms }}
<details class="mb3">
Expand Down Expand Up @@ -124,7 +124,7 @@ be wrapped in <p> tag by the Markdown renderer in Buildkite.
</div>
</details>
{{ end }}
<p class="p1">
<p>
<i>scan completed: <span title="{{ .FindingSummary.ImageScanCompletedAt }}">{{ .FindingSummary.ImageScanCompletedAt | timeAgo }}</span></i> |
<i>source updated: <span title="{{ .FindingSummary.VulnerabilitySourceUpdatedAt }}">{{ .FindingSummary.VulnerabilitySourceUpdatedAt | timeAgo }}</span></i>
</p>
2 changes: 1 addition & 1 deletion src/report/testdata/TestReports/findings_included.golden
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
</div>
</details>

<p class="p1">
<p>
<i>scan completed: <span title="&lt;nil&gt;"></span></i> |
<i>source updated: <span title="&lt;nil&gt;"></span></i>
</p>
Expand Down
4 changes: 2 additions & 2 deletions src/report/testdata/TestReports/image_label.golden
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<p class="h6 regular italic">test-repo@digest-value</p>


<p>No vulnerabilities reported.</p>
<p>No vulnerabilities reported.</p>



Expand All @@ -20,7 +20,7 @@



<p class="p1">
<p>
<i>scan completed: <span title="&lt;nil&gt;"></span></i> |
<i>source updated: <span title="&lt;nil&gt;"></span></i>
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
</div>
</details>

<p class="p1">
<p>
<i>scan completed: <span title="&lt;nil&gt;"></span></i> |
<i>source updated: <span title="&lt;nil&gt;"></span></i>
</p>
Expand Down
4 changes: 2 additions & 2 deletions src/report/testdata/TestReports/no_vulnerabilities.golden
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<h4>Vulnerability summary for "test-repo@digest-value"</h4>


<p>No vulnerabilities reported.</p>
<p>No vulnerabilities reported.</p>



Expand All @@ -19,7 +19,7 @@



<p class="p1">
<p>
<i>scan completed: <span title="&lt;nil&gt;"></span></i> |
<i>source updated: <span title="&lt;nil&gt;"></span></i>
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ Ignored to give the base image a chance to be updated
</div>
</details>

<p class="p1">
<p>
<i>scan completed: <span title="&lt;nil&gt;"></span></i> |
<i>source updated: <span title="&lt;nil&gt;"></span></i>
</p>
Expand Down
2 changes: 1 addition & 1 deletion src/report/testdata/TestReports/sorted_findings.golden
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
</div>
</details>

<p class="p1">
<p>
<i>scan completed: <span title="&lt;nil&gt;"></span></i> |
<i>source updated: <span title="&lt;nil&gt;"></span></i>
</p>
Expand Down

0 comments on commit 9e0a5ff

Please sign in to comment.