feat: support CVSS3 scores in rendered annotation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestelfer
changed the title
jamestelfer
force-pushed
the
support-cvss3
branch
2 times, most recently
from
c692b11 to
046dfc9
Compare
|
Example output from a build
|
ctgardner
reviewed
Nov 24, 2023
ctgardner
previously approved these changes
Nov 27, 2023
What sort of types? |
The mitre.org site is obsolescent, being replaced by the cve.org site with a new format. Switch over now: when AWS switches links they will continue to work. Also sometimes AWS is publishing links for advisories that aren't valid. Try to detect this and push to a GH vulnerability search instead.
Allows for easier adoption of CVSS3 score display.
Paves the way for the arrival of CVSS3 scores
CVSS3 scores are now shown preferentially, only falling back to CVSS2 when a CVSS3 score is not present.
Co-authored-by: Callum Gardner <callum.gardner@cultureamp.com>
jamestelfer
force-pushed
the
support-cvss3
branch
from
bd845fc to
7f19863
Compare
|
Rebased on |
ctgardner
approved these changes
Nov 30, 2023
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS has added support for CVSS3 scores and vectors in scan findings. These are included by preference, and CVSS2 scores are becoming less common, leading to lots of gaps in the detailed data that is rendered.
CVSS3 scores are now shown preferentially, only falling back to CVSS2 when a CVSS3 score is not present. A CVSS2 score will have "(*CVSS2)" added to the Score column to highlight that it is not directly comparable with other results in the table.
Based on the updated rendering types implemented in #25.