fix: result merging for multi-plat images needs to take PackageName and PackageVersion into account #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes running locally more approachable.
A detail is not unique by vulnerability, as I had presumed. PackageName and PackageVersion are part of the uniqueness: a single CVE can appear multiple times in a report against multiple packages.
Also, CVEs need to sort descending when repeated.
|
jamestelfer
changed the title
n-tucker
approved these changes
Mar 26, 2024
ctgardner
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Multi-platform images require multiple results to be merged. This was initially done using the CVE as the key for a finding detail. However, looking at real results from ECR it's apparent that the key is actually a triple:
Name(CVE),PackageNameandPackageVersion.This mismatch was causing results for multi-platform images that were inconsistent with an equivalent simple image reference.
Fixing this involved changing the comparer for the
Detailsstruct to look up by the three values, and ensuring that sorting in the report made sense.Context
Fixes issue introduced in #30