fix: React 17 fix - replace react-transition-group in draft-modal #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Here are your branch previews! ✨ Last updated for commit 52d432d: Merge branch 'master' into modal-react-17 |
lijuenc
force-pushed
the
modal-react-17
branch
2 times, most recently
from
5ba6ce6
to
8131af0
Compare
lijuenc
changed the title
lijuenc
changed the title
ActuallyACat
force-pushed
the
modal-react-17
branch
from
e4dd894
to
60b04b0
Compare
lijuenc
force-pushed
the
modal-react-17
branch
2 times, most recently
from
310f1a2
to
6025d1d
Compare
react-transition-group is not actively maintained and is not fully compatible with React 17
lijuenc
changed the title
dmisdm
pushed a commit
that referenced
this pull request
Apr 21, 2021
) * fix: React 17 fix - replace react-transition-group react-transition-group is not actively maintained and is not fully compatible with React 17 * Added tests to Confirmation modal * Reformat - fix linting errors * Fix typo * Add some tests for GenericModal * Add some tests for InformationModal * Add some tests for InputEditModal * Add some tests for RoadblockModal Co-authored-by: actuallyacat <allanna.beaton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Replace CSSTransition from react-transition-group with Transition from headlessui/react. The API is very close making it a near drop-in replacement.
For this PR, the relevant change happens in
GenericModal.scssandGenericModal.tsx. There is also a minor change toModal.elmto make the CSS class names consistent.The rest of the PR is adding tests to GenericModal and the presets we have (ConfirmationModal, InformationModal, InputEditModal, RoadblockModal) to hopefully catch issues like this in the future.
Motivation and Context
react-transition-group is not actively maintained (reactjs/react-transition-group#630 (comment)) and is not fully compatible with React 17 (https://github.com/cultureamp/kaizen-design-system/issues/1184).
Checklist
Additional Considerations
A basic test case has been added for GenericModal, however, we would like to have the test suite running in both React 16 and React 17 to catch issues such as this.