pr feedback

cultuurnet · Nov 15, 2024 · 41520ae · 41520ae
1 parent 6b3f36a
commit 41520ae
Showing 1 changed file with 21 additions and 21 deletions.
diff --git a/src/BackwardsCompatiblePayloadSerializerFactory.php b/src/BackwardsCompatiblePayloadSerializerFactory.php
@@ -418,8 +418,24 @@ function (array $serializedObject) use ($contactPointUpdatedEvent) {
             );
         }
 
-        self::fillDescriptions($payloadManipulatingSerializer);
+        $updateDescriptionEvents = [
+            EventDescriptionUpdated::class,
+            PlaceDescriptionUpdated::class,
+        ];
 
+        foreach ($updateDescriptionEvents as $descriptionUpdatedEvent) {
+            $payloadManipulatingSerializer->manipulateEventsOfClass(
+                $descriptionUpdatedEvent,
+                function (array $serializedObject) use ($descriptionUpdatedEvent) {
+                    $serializedObject = self::fillDescriptions($serializedObject);
+
+                    if ($descriptionUpdatedEvent === EventDescriptionUpdated::class) {
+                        return self::replaceEventIdWithItemId($serializedObject);
+                    }
+                    return self::replacePlaceIdWithItemId($serializedObject);
+                }
+            );
+        }
 
         /**
          * Roles
@@ -537,27 +553,11 @@ private static function addDefaultMainLanguage(array $serializedObject): array
         return $serializedObject;
     }
 
-    private static function fillDescriptions(PayloadManipulatingSerializer $payloadManipulatingSerializer): void
+    private static function fillDescriptions(array $serializedObject): array
     {
-        $updateDescriptionEvents = [
-            EventDescriptionUpdated::class,
-            PlaceDescriptionUpdated::class,
-        ];
-
-        foreach ($updateDescriptionEvents as $descriptionUpdatedEvent) {
-            $payloadManipulatingSerializer->manipulateEventsOfClass(
-                $descriptionUpdatedEvent,
-                function (array $serializedObject) use ($descriptionUpdatedEvent) {
-                    if (empty(trim($serializedObject['payload']['description']))) {
-                        $serializedObject['payload']['description'] = '---';
-                    }
-
-                    if ($descriptionUpdatedEvent === EventDescriptionUpdated::class) {
-                        return self::replaceEventIdWithItemId($serializedObject);
-                    }
-                    return self::replacePlaceIdWithItemId($serializedObject);
-                }
-            );
+        if (empty(trim($serializedObject['payload']['description']))) {
+            $serializedObject['payload']['description'] = '---';
         }
+        return $serializedObject;
     }
 }