Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-6310 Remove legacy Timestamp #1884

Open
wants to merge 10 commits into
base: III-6310-remove-legacy-OpeningHour
Choose a base branch
from
Open

III-6310 Remove legacy Timestamp #1884

wants to merge 10 commits into from

Conversation

LucWollants
Copy link
Contributor

Removed

  • Removed legacy Timestamp

Note

  • This pull request requires extra care when reviewing because it was not a simple search & replace

Ticket: https://jira.uitdatabank.be/browse/III-6310

@LucWollants LucWollants marked this pull request as ready for review November 14, 2024 08:36
grubolsch
grubolsch requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@grubolsch grubolsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have moved quite a mountain with this pr. :-)
Some minor remarks and one larger question related to the change of wording from "start/end" to "from/to".

features/event/update.feature Show resolved Hide resolved
src/Calendar/CalendarConverter.php Show resolved Hide resolved
src/Calendar/Calendar.php Show resolved Hide resolved
src/Calendar/Calendar.php Outdated Show resolved Hide resolved
src/Calendar/Calendar.php Outdated Show resolved Hide resolved
src/Calendar/Calendar.php Show resolved Hide resolved
src/Calendar/Calendar.php Outdated Show resolved Hide resolved
src/Calendar/Calendar.php Show resolved Hide resolved
src/Model/Serializer/ValueObject/Calendar/SubEventDenormalizer.php Show resolved Hide resolved
@LucWollants
Copy link
Contributor Author

You have moved quite a mountain with this pr. :-) Some minor remarks and one larger question related to the change of wording from "start/end" to "from/to".

Please take into account that the final goal is to also to remove the Calendar class. So I'm unsure how much effort we should put into modifying the working legacy code if we are going to remove it in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubolsch grubolsch grubolsch approved these changes

@JonasVHG JonasVHG Awaiting requested review from JonasVHG JonasVHG is a code owner

@simon-debruijn simon-debruijn Awaiting requested review from simon-debruijn simon-debruijn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucWollants @grubolsch