Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPS-5145 Added Keycloak #195

Merged
merged 4 commits into from
Jul 17, 2024
Merged

UPS-5145 Added Keycloak #195

merged 4 commits into from
Jul 17, 2024

Conversation

grubolsch
Copy link
Contributor

@grubolsch grubolsch commented Jul 16, 2024 •
edited
Loading

Added

  • Upgrade the Auth0 SDK and added Keycloak support.

Related to

https://github.com/cultuurnet/appconfig/pull/720

Ticket: https://jira.uitdatabank.be/browse/UPS-5145

LucWollants
LucWollants approved these changes Jul 16, 2024
View reviewed changes
Copy link

@LucWollants LucWollants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but I guess we wait with the merge until the server runs on 7.4 and we tested those changes?

@JonasVHG
Copy link
Contributor

I approved, but I guess we wait with the merge until the server runs on 7.4 and we tested those changes?

I've added the label wait-to-merge, which we also have in other projects, so it's clear for everyone involved.

Base automatically changed from UPS-5145/upgrade-to-php-7.4 to master July 17, 2024 07:46
@grubolsch grubolsch merged commit fb00f16 into master Jul 17, 2024
2 checks passed
@grubolsch grubolsch deleted the UPS-5145/keycloak branch July 17, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVHG JonasVHG JonasVHG approved these changes

@LucWollants LucWollants LucWollants approved these changes

Assignees
No one assigned
Labels
wait-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grubolsch @JonasVHG @LucWollants