UPS-5225 BUGFIX since upgrade auth0 lib we are missing the login params #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG and
simon-debruijn
as code owners
JonasVHG
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Since the last auth0 library upgrade, we are missing the login params.
It was now the second param instead of the thirth param.
I also fixed another bug where it would always use the login_params and app_url of the auth0 config, not the keycloak config. (they are normally the same, but still confusing).
Ticket: https://jira.uitdatabank.be/browse/UPS-5225