Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh: FreeBSD amd64 #385

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

guest20
Copy link
Contributor

@guest20 guest20 commented Jul 26, 2024

As a drive by commiter, I want installer script to work on my janky freebsd vps so I can backups

What it does

  • Add freebsd to the NATIVE_OS check
  • Add amd64 to the NATIVE_ARCH check

This PR feels a little "got mine", but I don't think it'll hurt anybody else.

What I could have done instead

These seem like too much for a drive-by commit

  • generate install.sh as part of the release process so it knows which releases are worth trying
  • rewrite the script to check arch within each OS check (since amd64 might not be a good arch choice for linux?)

Contributor agreement

The patch is yours if you want it, and I don't have to be in the authors/credits/change log etc

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
autorestic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 0:59am

@cupcakearmy
Copy link
Owner

Thanks :)

@cupcakearmy cupcakearmy merged commit dd01e97 into cupcakearmy:master Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants