fix: --draft flag works when creating a PR with rebase #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClairePhi
force-pushed
the
ClairePhi/pr/201
branch
2 times, most recently
from
6a3f6a7 to
e13720d
Compare
ClairePhi
force-pushed
the
ClairePhi/pr/201
branch
from
e13720d to
1f2d7c9
Compare
ClairePhi
changed the title
cupcicm
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a PR with a rebase (e.g.
opp pr -ioropp pr --base xxx), the--draftflag doesn't work.This is because the value of
--draftwas not taken from the previous Args when building the new Args.This PR makes a deep copy of the args in order to make sure that the previous Args are taken into account.