Fixes a deadlock in opp clean
#204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are more than 10 PRs to clean, we will pull from the results channel only when we have managed to correctly enqueue all the `cleanPR` goroutines. But this can happen only if we manage to acquire enough slots in the semaphore. And the semaphore releases only when it manages to push a message to the results channel => 💥
epot
approved these changes
Dec 16, 2024
ClairePhi
force-pushed
the
ClairePhi/pr/204
branch
3 times, most recently
from
6c797e5 to
12e3944
Compare
ClairePhi
force-pushed
the
ClairePhi/pr/204
branch
from
12e3944 to
fae7776
Compare
|
We need to take a closer look at how to delete multiple branches in parallel. In the mean time, we will close this PR and revert the PR that parallelizes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are more than 10 PRs to clean, we will
pull from the results channel only when we have managed
to correctly enqueue all the
cleanPRgoroutines.But this can happen only if we manage to acquire
enough slots in the semaphore. And the semaphore
releases only when it manages to push a message to
the results channel
=> 💥