Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss37 define scoot sublanguage #47

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

smover
Copy link
Collaborator

@smover smover commented Jun 14, 2017

No description provided.

@smover smover self-assigned this Jun 14, 2017
smover added 10 commits June 14, 2017 14:39
Structured docs around expected language subset, add references, minijava syntax.
Add simple test cases for boolean operators.
Add the test cases for the comparison operators supported in Javita.
Add the test cases for the control flow (sequences, conditionals,
loops, static method calls).
Add a list of features included and excluded in the Javita language.
@smover
Copy link
Collaborator Author

smover commented Sep 15, 2017

The pull request add a list of features supported by the language (I did not define a syntax or a formal semantic) and a set of test cases for the supported features.

I would like to get feedback on how to improve the tests (e.g. is the structure of the test ok? Are there corner cases in the semantic that we want to test?) and then merge the current changes .

Fix the code style warning for the use of duplicate string literals
and duplicate imports whthout using string brackets.
@smover smover requested a review from jpw234 September 15, 2017 16:55
@smover smover changed the title WIP: Iss37 define scoot sublanguage Iss37 define scoot sublanguage Oct 6, 2017
@smover smover requested a review from ftc October 6, 2017 16:19
@smover
Copy link
Collaborator Author

smover commented Oct 6, 2017

@ftc This is the pull request we were talking about. Could you check if the structure of the test cases is adequate?

The idea is that these should be test cases in the java subset that the concrete interpreter should be able to run.

@@ -0,0 +1,7 @@
package edu.colorado.plv.cuanto.javita;

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add why we have this?

(e()) should equal (n)
}}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flip the forAll and test so that you get not one big test but many small tests

behavior of "Arithmetic operators"
val exprTests = Table(
(mcString, resString),
(Expressions.testExpr1 _,3),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this table be a mapping from "method keys" to values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants