Feature spa heater functionality #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change is specific to build errors
had to make changes to noImplicitAny due to the following error during build. error TS7016: Could not find a declaration file for module '@homebridge/dbus-native'
had to make changes to noImplicitAny due to the following error during build. error TS7016: Could not find a declaration file for module '@homebridge/dbus-native'
-new functionality to parse pool mode -changed GetDeviceState to ParseDeviceState -moved api calls out of parse functions into its own function getResponse -dded new sleep function -added requester parameters to functions for better logging
-moved checking device state into its own function so it can be used by both setOn and getOn -updated setOn and getOn to use the new ParseState -refactored setOn for better efficiency and readability -tweaked logging messages to be a bit more readable
initial commit of new device used for toggling pool, spa, and or spillover.
-added missing log entry for when getResponse fails.
-refactored to use named exports -added ACCESSORY_MODE const -renamed SpaMode to Spa -added Pool and Spillover accessories -
-refactored how accessories are loaded -added functionality for new ModeSwitch device, for Pool, Spa, & Spillover -added cacheing functionality for api requests made to the AquaConnect bridge -added check to ensure disclaimer has been accepted
-disabled noImplicitAny
-added new disclaimer -updated all settings to be hidden until disclaimer is accepted -added new setttings for --Get Request Cache Threshold --Get Request Delay --Set Request Delay -Added Pool, Spa, Spillover, and Heater to Include Accessories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to support new functionality for toggling the pool, spa, or spillover mode and adding heater accessory.