fix broadcasting behavior in ndimage.measurements functions #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
approved these changes
Oct 21, 2020
emcastillo
added
to-be-backported
|
Jenkins, test this please |
|
Jenkins CI test (for commit 5dc9a61, target branch master) succeeded! |
|
@emcastillo This pull-request is marked as |
emcastillo
pushed a commit
to emcastillo/cupy
that referenced
this pull request
Oct 29, 2020
…an_fix fix broadcasting behavior in ndimage.measurements functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cupyx.scipy.ndimage.measurementsfunctionssum,mean,varianceandstandard_deviationcurrently do not broadcast the labels argument properly in all cases.The call to
cupy.broadcast_arraysjust needs to precede any calls likeinput[labels > 0]orinput[labels == index]as proposed here.The test cases added here fail on master, but pass after the changes in this PR.