[MAINTENANCE] Refactor TarBag to remove global variables #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**ISSUE** A number of instance variables were used to pass values across methods which made code linkages and dependencies difficult to analyze. **RESOLUTION** This change removes all instance variables in the class and passes required data as paramaters to the method calls. Where data from the instance initialization is required, we've replaced references to instance variables with corresponding attribute readers. This change also adds more detailed testing of the TAR file that gets created to confirm it has the esxpected content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
A number of instance variables were used to pass values across methods which made code linkages and dependencies difficult to analyze.
RESOLUTION
This change removes all instance variables in the class and passes required data as paramaters to the method calls. Where data from the instance initialization is required, we've replaced references to instance variables with corresponding attribute readers.
This change also adds more detailed testing of the TAR file that gets created to confirm it has the esxpected content.