create internal trustedTypes policy only if not specified via config object #801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before #800:
After #800:
sanitize
andsetConfig
allow switching from the internal policy to a user provided one whenTRUSTED_TYPES_POLICY
configuration option is passed via the configuration object.This PR:
sanitize
orsetConfig
if and only ifTRUSTED_TYPES_POLICY
configuration option is not specified in the configuration object. This maintains behavior prior to support TRUSTED_TYPES_POLICY configuration option #800.Background & Context
See #798 for the background discussion.
Note: since the original
loadDOMPurify
test helper was performing a call tosanitize
without any configuration option this triggered the creation of the internal policy and I could not write a test to validate that there is no policy created when supplyingTRUSTED_TYPES_POLICY
configuration option. I had to refactor the helper to allow writing a new test which specifically looks for the number of policies created when DOMPurify is loaded on the page and after calls tosanitize
.Tasks