Added support for the Angular compiler. #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Angular compiler looks for the main field using a few fields in the package.json. The order it uses is: - es2020 - es2015 - browser - module - main The first entry the Angular compiler would find before this change was the 'browser' entry point. This is however compiled as an `umd` and Angular is looking for an `esm` so it would complain (it would still work though). Adding `es2020` as an entry point fixes this problem.
|
I don't known how I did it but somehow I changed more files than I wanted, will try to amend this commit. Edit: Never mind it is a pre-commit step so it's probably meant to do this. |
|
Most excellent, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Angular compiler looks for the main field using a few fields in the package.json. The order it uses is:
The first entry the Angular compiler would find before this change was the 'browser' entry point. This is however compiled as an
umdand Angular is looking for anesmso it would complain (it would still work though). Addinges2020as an entry point fixes this problem.Fixes #869
Background & Context
Tasks
npm install --save ./path/to/projectDOMPurifyin theAppComponentand just sanitize some string in thengOnInitfunctionnpm run buildto build this application and see that the warning about common js modules is resolved.Dependencies