Added support for different response modes #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrojanowski
requested changes
Aug 26, 2022
There was a problem hiding this comment.
Hey @ravidshachar, thanks for the contribution. Really nice change.
I left one comment with a proposition for a slight change in the proposed feature.
| @@ -114,6 +114,7 @@ def start_code_flow(): | |||
| scopes, request.args.get("forceConsent", False), | |||
| request.args.get("allowConsentOptionDeselection", False), | |||
| request.args.get("responseType", "code"), | |||
| _config.get("response_mode", "query"), | |||
There was a problem hiding this comment.
I think it's better to leave the decision about the response mode to the client. You changed the backend so that it will work with both modes, which is good. Now the client could decide which mode to use:
request.args.get("response_mode", "query"),
The response_mode could be then removed from the settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for additional response modes such as form_post