urldata: tweak the UserDefined struct #16097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By better sticking to listing the struct members sorted by size, this struct is now 48 bytes smaller on my fairly maximized build, without removing anything. Turned 'connect_only' into two bits instead of an unsigned char with two magic values. Also put the 'gssapi_delegation' field within ifdef HAVE_GSSAPI.
|
Analysis of PR #16097 at fcefc2f1: Test 1191 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By better sticking to listing the struct members sorted by size, this struct is now 48 bytes smaller on my fairly maximized build, without removing anything.
Turned 'connect_only' into two bits instead of an unsigned char with two magic values.
Also put the 'gssapi_delegation' field within ifdef HAVE_GSSAPI.