if query is not updated, leave it untouched #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the tests accordingly. Fixes #281
jacobmealey
reviewed
Apr 18, 2024
| if(nq) { | ||
| int rc = curl_url_set(uh, CURLUPART_QUERY, nq, 0); | ||
| if(rc) | ||
| trurl_warnf(o, "internal problem"); |
There was a problem hiding this comment.
i know this isn't a new warning but im wondering if we can make this more descriptive?
There was a problem hiding this comment.
oops looks like i was a minute late to the party haha
There was a problem hiding this comment.
well, we can/should still improve the warning!
There was a problem hiding this comment.
it should be extremely rare to see this...
bagder
added a commit
that referenced
this pull request
Apr 18, 2024
bagder
added a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the tests accordingly.
Fixes #281