Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minor fixes based on manual tests #14

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Implement minor fixes based on manual tests #14

merged 2 commits into from
Jan 15, 2024

Conversation

denessapi
Copy link
Collaborator

No description provided.

Do not use the bootTime as that can cause the sensor and touch
timestamps to become incorrect.
Always restart the collection if the battery or network status changes.
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5fde1b2) 79.20% compared to head (07381e4) 79.28%.

❗ Current head 07381e4 differs from pull request most recent head 89d883a. Consider uploading reports for the commit 89d883a to get more accurate results

Files Patch % Lines
Sources/Trap/Manager/Manager.swift 90.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   79.20%   79.28%   +0.08%     
==========================================
  Files          60       60              
  Lines        4602     4616      +14     
==========================================
+ Hits         3645     3660      +15     
+ Misses        957      956       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denessapi denessapi requested a review from gbence January 15, 2024 09:46
@denessapi denessapi merged commit afb9f9e into main Jan 15, 2024
2 checks passed
@denessapi denessapi deleted the denes/fixes branch January 21, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants