feat: Always perform window enumeration on the main thread #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not guaranteed that the subscribe and unsubscribe methods are called from the main thread, but window enumeration should always happen on the main thread. To ensure it the window enumeration has to be dispatched to the main thread.
denessapi
force-pushed
the
denes/changes-for-capacitor-plugin
branch
from
5569c42 to
eb55095
Compare
The Xcode version should be set on macOS13 as well, as the latest version does not support IOS 16.
denessapi
force-pushed
the
denes/changes-for-capacitor-plugin
branch
from
c4fb842 to
3ac8048
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 79.29% 79.24% -0.05%
==========================================
Files 60 60
Lines 4617 4636 +19
==========================================
+ Hits 3661 3674 +13
- Misses 956 962 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not guaranteed that the subscribe and unsubscribe methods are called from the main thread, but window enumeration should always happen on the main thread. To ensure it the window enumeration has to be dispatched to the main thread.