Snippet wrap #94
Merged
Snippet wrap #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Oct 17, 2021
pokey
commented
Oct 17, 2021
src/actions/wrap.py
Outdated
| wrapper_snippets = { | ||
| "else state": "cursorless.wrapper.ifElseStatementElseBranch", | ||
| "if else": "cursorless.wrapper.ifElseStatementIfBranch", | ||
| "if state": "cursorless.wrapper.ifStatement", |
There was a problem hiding this comment.
Note: this term is configured independently from "if state" the scope type. Could be surprising to users but I wasn't sure of the right approach here because there are multiple ways to wrap something with an if statement and I could see people wanting to wrap differently from how they refer to scope type maybe? Also, fwiw, I have configured this to "if" for myself, because I think I can get away with shorter name than when it's used for a scope type
pokey
commented
Oct 23, 2021
src/actions/wrap.py
Outdated
Comment on lines
26
to
29
| "else": "ifElseStatement/alternative", | ||
| "if else": "ifElseStatement/consequence", | ||
| "if": "ifStatement/consequence", | ||
| "try": "tryCatchStatement/body", |
There was a problem hiding this comment.
Note the new <snippet name>/<variable name> syntax here
AndreasArvidsson
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also cursorless-dev/cursorless#296