Workaround / fix tree-sitter wildcard issue #1609
Assignees
Labels
bug
Something isn't working
code quality
Improvements to code quality
to discuss
Plan to discuss at meet-up
Milestone
Comments
pokey
added
bug
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 17, 2023
- Fixes #1609 - Required by / tested by #1448 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See tree-sitter/tree-sitter#2484. That issue is a blocker for us, because the workaround of explicitly listing all possible types instead of using
_is quite painful. The maintainers seem to be completely ignoring the issue, and hopefully it won't be too bad to fix (🤞), so let's tackle it ourselves.Alternately, we could work around it by just not passing in offsets to
query.matches. That is not great from a performance perspective, but might be a reasonable solution for now. Fwiw if the user uses "next", we are currently running the query on the whole document starting from target start, so we already are running large queries sometimes. Obv could improve that by exponentially growing search range, but we don't yet, so probably fine to hack here as well for nowThe text was updated successfully, but these errors were encountered: