Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge sequential pending change highlights #2

Closed
pokey opened this issue Jun 21, 2021 · 3 comments · Fixed by #141
Closed

Merge sequential pending change highlights #2

pokey opened this issue Jun 21, 2021 · 3 comments · Fixed by #141
Assignees
@AndreasArvidsson
Labels
bug Something isn't working

Comments

@pokey
Copy link
Member

pokey commented Jun 21, 2021

There are a couple commands where the pending change highlights appear in sequence. This slows down the action and makes it so that sometimes the cursorless decorations will move before another command can be executed. We'd like to make these commands show the highlights at the same time. The commands are:

  • use
  • carve
@pokey pokey added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 23, 2021
@AndreasArvidsson AndreasArvidsson self-assigned this Jul 25, 2021
@AndreasArvidsson AndreasArvidsson mentioned this issue Jul 26, 2021
Merged
@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Jul 26, 2021 •
edited
Loading

Could you expand on how you want the move/bring/swap decorations to function? Today the decorations do the following:

  1. Decorate targets
  2. Perform action/swap
  3. Decorate result/that mark

We could just remove step 3?

@pokey
Copy link
Member Author

pokey commented Jul 26, 2021

I think this one was basically solved by reducing highlight time. The issue was if you say "carve air take bat" in one command, the "bat" highlight would have changed because redecoration debounce was too short relative to highlight timeout. I don't think that's an issue anymore but prob worth retesting just to be sure.

@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Jul 26, 2021 •
edited
Loading

Okay but for cut it's already fixed anyways :)
#141

@AndreasArvidsson AndreasArvidsson linked a pull request Jul 29, 2021 that will close this issue
Use built in action for copy and paste #141
Merged
pokey pushed a commit that referenced this issue Apr 2, 2023
@MartinRykfors
Improve relative / ordinal diagram in the docs (#1277)
d5aa63d 
## Checklist

- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] I have tested building the docs

Replace the hand-written diagram of relative / ordinal modifiers with
one generated by LaTeX / tikz.

If it is necessary in the future to change this image, you can reuse and
modify the below latex code to regenerate it.

```
\documentclass[tikz]{standalone}
\usepackage{tikz}
\usetikzlibrary{decorations.pathreplacing,calligraphy}

% to convert pdf -> png:
% convert -density 300 relative-ordinal.pdf -quality 100 -background white -alpha remove relative_ordinal.png

\begin{document}
\def\spacing{1.4cm}
\newcommand{\ibrace}[4]{
    \draw [decorate, decoration = {brace, amplitude=5pt}] (#2*\spacing, #1*0.8cm + 0.5cm) --  (#3*\spacing, #1*0.8cm + 0.5cm)
    node[above=5pt, pos=0.5, scale=0.8] {\texttt{"#4"}};
}
\newcommand{\bbrace}[4]{
    \draw [decorate, decoration = {brace, amplitude=5pt}] (#2*\spacing, #1*0.8cm + 0.5cm) --  (#3*\spacing, #1*0.8cm + 0.5cm)
    node[above=-20pt, pos=0.5, scale=0.8] {#4};
}
\newcommand{\funk}[3]{
    \draw[fill=black] (#1*\spacing,0) circle (0.1cm) node[below=#2, text width=1cm,align=left,scale=0.7] (F#1)
    {\texttt{"#3"}};
}
\begin{tikzpicture}[ultra thick]

\funk{0}{0pt}{first funk}
\funk{1}{0pt}{second funk}
\funk{2}{0pt}{third previous funk}
\funk{3}{0pt}{second previous funk}
\funk{4}{0pt}{previous funk}
\funk{5}{0pt}{funk}
\funk{6}{0pt}{next funk}
\funk{7}{0pt}{second next funk}
\funk{8}{0pt}{third next funk}
\funk{9}{0pt}{second last funk}
\funk{10}{0pt}{last funk}

\draw[latex-] (F5) -- +(0,-0.8cm) node[below=2pt,scale=0.8] {input target};

\ibrace{0}{6}{8}{next three funks};
\ibrace{0}{2}{4}{previous three funks};
\ibrace{1}{5}{7}{three funks};
\ibrace{2}{3}{5}{three funks backward};
\ibrace{0}{0}{1}{first two funks};
\ibrace{0}{9}{10}{last two funks};
\bbrace{-3}{10}{0}{iteration scope};
\end{tikzpicture}

\end{document}
```

---------

Co-authored-by: Martin Rykfors <martin.rykfors@evolabel.com>
saidelike added a commit to fidgetingbits/cursorless that referenced this issue Jul 19, 2024
@saidelike
Merge pull request cursorless-dev#2 from fidgetingbits/neovim
7ddc06f 
feat: make the shortcut platform specific as default and configurable by the user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasArvidsson AndreasArvidsson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use built in action for copy and paste cursorless-dev/cursorless
2 participants
@pokey @AndreasArvidsson