Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "past end of line" #4

Closed
pokey opened this issue Jun 22, 2021 · 7 comments
Closed

Fix "past end of line" #4

pokey opened this issue Jun 22, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@pokey
Copy link
Member

pokey commented Jun 22, 2021

When issuing a command such as "chuck gust past end of line", cursorless incorrectly assumes that "end of line" refers to the current cursor line rather than the line containing "gust".
@pokey pokey added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 23, 2021
@pokey
Copy link
Member Author

pokey commented Jul 6, 2021

Fwiw I think this one will fall out of the inference rewrite for #69

@AndreasArvidsson AndreasArvidsson mentioned this issue Jul 16, 2021
Merged
@pokey pokey reopened this Dec 24, 2021
@pokey
Copy link
Member Author

pokey commented Dec 24, 2021

Pretty sure this one is still a problem

@AndreasArvidsson
Copy link
Member

What exactly isn't working? What I can tell it works as expected and we do have a test for it.
https://github.com/pokey/cursorless-vscode/blob/main/src/test/suite/fixtures/recorded/inference/takeAirPastEndOfLine.yml

@pokey
Copy link
Member Author

pokey commented Dec 25, 2021

I believe "chuck air past end of line" deletes the trailing newline, which, while I understand why it happens, is not desired. It should behave the same as "tail"

@AndreasArvidsson
Copy link
Member

I agree that its not the desired behavior but also not really the same problem described in this issue.

@pokey
Copy link
Member Author

pokey commented Dec 25, 2021

Ah right sorry should have read it closer 😅

@pokey pokey closed this as completed Dec 25, 2021
@pokey
Copy link
Member Author

pokey commented Dec 25, 2021

For posterity's sake, the proper issue is #209

pokey pushed a commit that referenced this issue Apr 2, 2023
@MartinRykfors
Improve relative / ordinal diagram in the docs (#1277)
d5aa63d 
## Checklist

- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] I have tested building the docs

Replace the hand-written diagram of relative / ordinal modifiers with
one generated by LaTeX / tikz.

If it is necessary in the future to change this image, you can reuse and
modify the below latex code to regenerate it.

```
\documentclass[tikz]{standalone}
\usepackage{tikz}
\usetikzlibrary{decorations.pathreplacing,calligraphy}

% to convert pdf -> png:
% convert -density 300 relative-ordinal.pdf -quality 100 -background white -alpha remove relative_ordinal.png

\begin{document}
\def\spacing{1.4cm}
\newcommand{\ibrace}[4]{
    \draw [decorate, decoration = {brace, amplitude=5pt}] (#2*\spacing, #1*0.8cm + 0.5cm) --  (#3*\spacing, #1*0.8cm + 0.5cm)
    node[above=5pt, pos=0.5, scale=0.8] {\texttt{"#4"}};
}
\newcommand{\bbrace}[4]{
    \draw [decorate, decoration = {brace, amplitude=5pt}] (#2*\spacing, #1*0.8cm + 0.5cm) --  (#3*\spacing, #1*0.8cm + 0.5cm)
    node[above=-20pt, pos=0.5, scale=0.8] {#4};
}
\newcommand{\funk}[3]{
    \draw[fill=black] (#1*\spacing,0) circle (0.1cm) node[below=#2, text width=1cm,align=left,scale=0.7] (F#1)
    {\texttt{"#3"}};
}
\begin{tikzpicture}[ultra thick]

\funk{0}{0pt}{first funk}
\funk{1}{0pt}{second funk}
\funk{2}{0pt}{third previous funk}
\funk{3}{0pt}{second previous funk}
\funk{4}{0pt}{previous funk}
\funk{5}{0pt}{funk}
\funk{6}{0pt}{next funk}
\funk{7}{0pt}{second next funk}
\funk{8}{0pt}{third next funk}
\funk{9}{0pt}{second last funk}
\funk{10}{0pt}{last funk}

\draw[latex-] (F5) -- +(0,-0.8cm) node[below=2pt,scale=0.8] {input target};

\ibrace{0}{6}{8}{next three funks};
\ibrace{0}{2}{4}{previous three funks};
\ibrace{1}{5}{7}{three funks};
\ibrace{2}{3}{5}{three funks backward};
\ibrace{0}{0}{1}{first two funks};
\ibrace{0}{9}{10}{last two funks};
\bbrace{-3}{10}{0}{iteration scope};
\end{tikzpicture}

\end{document}
```

---------

Co-authored-by: Martin Rykfors <martin.rykfors@evolabel.com>
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this issue Mar 27, 2024
@AndreasArvidsson @pokey
Created capture for wrap action (cursorless-dev#4)
4e1fc29 
* Created capture for wrap action

* Use command with args func

* Update src/command.py

Co-authored-by: Pokey Rule <pokey.rule@gmail.com>

* Update src/actions.py

Co-authored-by: Pokey Rule <pokey.rule@gmail.com>

* Update src/command.py

Co-authored-by: Pokey Rule <pokey.rule@gmail.com>

* Update src/command.py

Co-authored-by: Pokey Rule <pokey.rule@gmail.com>

* to rename to wrappers

* Update src/actions.py

Co-authored-by: Pokey Rule <pokey.rule@gmail.com>

* renamed capture to singular

* replaced tabs with spaces

Co-authored-by: Andreas Arvidsson <andreas.arvidsson@redpill-linpro.com>
Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this issue Jun 13, 2024
@saidelike
Merge pull request cursorless-dev#4 from fidgetingbits/neovim-lua-plu…
6ea4985 
…gin-registry

refactor: register node plugins using lua instead of vimscript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pokey @AndreasArvidsson