Skip to content

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 24, 2022

updates:
- [github.com/pre-commit/mirrors-prettier: v2.7.1 → v3.0.0-alpha.3](pre-commit/mirrors-prettier@v2.7.1...v3.0.0-alpha.3)
- [github.com/wenkokke/talonfmt: 1.8.0 → 1.8.1](wenkokke/talonfmt@1.8.0...1.8.1)
@pre-commit-ci pre-commit-ci bot requested a review from pokey as a code owner October 24, 2022 22:53
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 21e30ea to d93922a Compare October 24, 2022 22:53
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give up. You win, pre-commit. I hope you're happy Actually, this will put our prettier out of sync with what's in package.json. I really wish there were a bot that kept them in sync. I wonder if dependabot or renovate will do that

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind; see above

@auscompgeek
Copy link
Member

Huh, weird there are commas that weren't added by prettier 2.

@pokey
Copy link
Member

pokey commented Oct 25, 2022

Fwiw it looks like Renovate does have beta support for updating pre-commit. Maybe we should do an experiment with that? Might be able to make it so that it updates pre-commit and package.json in tandem

Love this btw:

Renovate's approach to version updating is not fully aligned with pre-commit upgrade and this has caused frustration for pre-commit's creator/maintainer. Attempts to work with the pre-commit project to fix these gaps have been rejected, so we have chosen to disable the manager by default indefinitely. Please do not contact the pre-commit project/maintainer about any Renovate-related topic.

😂 how dare they respect semver

@pokey
Copy link
Member

pokey commented Oct 25, 2022

Ok Renovate looks pretty cool, and looks like it doesn't try to upgrade to alpha. See #1090. I wonder how you turn off pre-commit autoupdate 🤔. A quick Google didn't turn up much, and their web ui doesn't seem to have anything

@auscompgeek
Copy link
Member

auscompgeek commented Oct 25, 2022

Last I looked through the docs and issues, pre-commit.ci explicitly doesn't support disabling autoupdate PRs, and I don't believe it's possible to configure pre-commit to skip updating particular hooks.

@pokey
Copy link
Member

pokey commented Oct 25, 2022

It is impressive how opinionated pre-commit is 😅

I guess I can just close a PR once a week. Not that big of a deal 🤷‍♂️

@pokey pokey closed this Oct 25, 2022
@pokey pokey deleted the pre-commit-ci-update-config branch October 25, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants