-
-
Notifications
You must be signed in to change notification settings - Fork 85
Added paragraph scope handler #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pokey Updated with new generator format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Worth migrating all block tests to scopes/paragraph
directory and then seeing what's missing. Upon a quick glance I didn't see any "next", "previous", or "n blocks" tests. Worth having some with edge cases too. I think probably want cross product of:
- empty cursor at start of block
- empty cursor in middle of block
- empty cursor at end of block
Cross with
- "block"
- "next block"
- "previous block"
- "two blocks"
- "two blocks backward"
It looks like we already have a few "every" tests, so probably ok on that front? Worth quick review tho
A bit annoying we still have to do all these cross products. If we tested the scope handler directly we could do many fewer tests 🤔
Tests added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid
Fixes #1055
Checklist