Update editor config indent

[AndreasArvidsson]

Checklist

• I have added tests
• I have updated the docs and cheatsheet
• I have not broken the cheatsheet

[auscompgeek]

Curious why? FWIW Prettier has an open issue to switch the default to tabs.

[AndreasArvidsson]

Curious why? FWIW Prettier has an open issue to switch the default to tabs.

The main reason is this
https://github.com/cursorless-dev/cursorless/pull/1126/files#diff-ce616deccd5f516e1b391ea2e6dd39c415e0959a3c72cf8e17a4635023437a6b

The left hand side is more whitespace than actual content. Also I prefer to just have the same indentation settings no matter the language.

[auscompgeek]

The left hand side is more whitespace than actual content.

I don't understand; I see the same amount of whitespace in both.

To be doubly-sure I even disabled browser extensions that mess with the GitHub UI.

[AndreasArvidsson]

@auscompgeek This is how it looks for me. I'm pretty sure @pokey had a similar problem.

[auscompgeek]

Still looks reasonable to me in split diff mode.

[pokey]

Looks like it's a GitHub setting

The advantage of tabs is that you can decide how wide you want them to be

[AndreasArvidsson]

Looks like it's a GitHub setting

The advantage of tabs is that you can decide how wide you want them to be

Cool thanks, but since 8 is the default spaces have the advantage of being consistent. Personally I don't se why you would want tabs in some languages and spaces in other.

[pokey]

The argument would be to use tabs everywhere

[AndreasArvidsson]

The argument would be to use tabs everywhere

I much rather have tabs than mixing

[pokey]

I think tabs are better in theory, but I worry that in practice they may be a bit cumbersome. Eg

• by default our code will look crazy spaced out on Github, as most users won't have tweaked their tab render setting
• VSCode kind of handles configuring tab display width, but it is a bit wonky (see eg bug: tabSize affects indentation microsoft/vscode#10339 and Separate tab size and indent size microsoft/vscode#42740)

@auscompgeek if you are planning to make it to meet-up today maybe we can discuss then

[phillco]

+1 on just converting everything to spaces.

Also, lol at that list of merge conflicts :)

[AndreasArvidsson]

+1 on just converting everything to spaces.

Also, lol at that list of merge conflicts :)

After today's session we went other route and actually changed everything into tabs :D

[phillco]

Ah well. As long as it's consistent.

[pokey]

Huh https://code.visualstudio.com/updates/v1_74#_new-indent-size-setting cc/ @auscompgeek @AndreasArvidsson

[auscompgeek]

Oh goodie, I can finally convert my vim config to VSCode

[pokey]

For now, let's stick to spaces, as the tooling hasn't really caught up with tabs yet, eg:

• yaml heredocs converting to inline strings,
• yaml not supporting tab indentation
• VSCode disallowing auto-indent detection,
• GitHub large spaces by default

We can revisit once Prettier 3 comes out

[AndreasArvidsson]

@pokey Updated once again with space indentation