Implement our own types instead of vscode #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
pokey
reviewed
Nov 16, 2022
pokey
reviewed
Nov 16, 2022
|
Ok I'm going to add a few more tests and then I think it's good to go! Should we drive this one for a day just in case? It does touch about half of our files 🤔 |
|
We can if you like but with two and a half thousand tests I'm feeling pretty comfortable |
pokey
approved these changes
Nov 16, 2022
|
Looks good. |
AndreasArvidsson
added a commit
that referenced
this pull request
Dec 15, 2022
If you have a selection spanning more than one line, and your selection is not reversed, and you scroll offscreen, Cursorless won't prioritise hats on lines closer to your cursor Unfortunately this one is hard to test until we have better mocking capabilities Noticed this while reviewing #1128 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
SelectionTextLine