Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pre-commit install from nix dev shell (#2461) #2471

Merged
merged 1 commit into from
Jul 9, 2024
Merged

remove pre-commit install from nix dev shell (#2461) #2471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
buildInputs = [ pkgs.bashInteractive ];
shellHook = ''
if [ ! -f .git/hooks/pre-commit ]; then
pre-commit install
echo "You can run 'pre-commit install' to install git commit hooks if you want them."
fi

pnpm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the pre-commit install has been removed, should we remove the pnpm install too? It's not exactly fast when you consider how fast a shell typically starts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unfortunately lack some understanding about how nix works, but I would imagine that when creating the environment, we want to do a pnpm install, but not when just activating the shell. Not sure if that makes sense / is possible

Expand Down
Loading