- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 88
Enable initial r support #2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable initial r support #2721
Conversation
I'm marking this as ready to make adding scopes easier. Once r support is included in cursorless, it will be easier for it to pick it up as an option for adding scopes |
Latest version of the parse tree is published and should be available in the marketplace very soon. |
@AndreasArvidsson ready to review! Thank you again for your help yesterday |
Please add a scope test for an empty argument list as well. The difference is the insertion delimiter. Please have a look at how it's implemented in other languages. |
I would recommend that you create multiple scope files for the same facet instead of adding multiple different code examples in the same file. It's much simpler to review it that way. |
8bb8dee
to
3bf717c
Compare
packages/cursorless-org-docs/src/docs/contributing/adding-a-new-language.md
Outdated
Show resolved
Hide resolved
Looks like you're starting to get the hang of this :)
|
Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
@BlueDrink9 Regarding iteration domain for arguments |
I'm still wrapping my head around treesitter to add the supported scopes, so I'll update this PR and add relevant tests once I do + once the r PR is added to vscode's parse tree
Checklist