Join sources on single destination #339
Conversation
There was a problem hiding this comment.
Tbh I find the impl a bit confusing, but I'm going to rework this code soon anyways so happy to leave it as long as it has decent test coverage. But would be good to add tests for the following:
- A couple "before" examples
- Another delimited scope type, eg "arg"
|
The only thing I changed was to join the text on multiple sources into one destination |
Yeah I mean adding tests where you bring multiple before. I could see that getting broken somehow where we end up adding two delimiters. And same adding tests where we bring multiple to a target that is an arg. Also prob useful "bring air and bat to arg cap"; I think currently your tests just do after and cursor |
|
I understand in completely agree. Tests added |
| b | ||
| c | ||
|
|
||
| const values = [e, a, b, c] |
There was a problem hiding this comment.
This is great. I get the impression these extra tests might have found a bug 😊
Maybe
There was a problem hiding this comment.
It is really cool!
No description provided.