-
-
Notifications
You must be signed in to change notification settings - Fork 92
Run pre-commit #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pre-commit #638
Conversation
3668596 to
90a89d6
Compare
| @@ -1 +1 @@ | |||
| hello world | |||
| hello world | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the added new line here is causing tests to fail; easy fix
37b9f85 to
1168bf8
Compare
1168bf8 to
94c4f4a
Compare
|
Maybe add a * text=auto eol=lfwhich should force CI on Windows to check out the file with Unix line endings. |
Ok so first of all TIL so thanks for that 😄 Any objection to just doing https://github.com/cursorless-dev/cursorless/pull/638/files#diff-bcd60fce722e3a07bb2e897fc863f9e0f9baff1e2667a348730b3ee310d85661R72? Seems simpler, and doesn't really alter the goal of the test, which is to ensure that it is opening the correct document |
30a8ef7 to
4c06767
Compare
|
Fwiw I've split this PR into 2 commits. The first commit (c8815db) consists of manual changes which have some (slight 😊) substance. The second commit (4c06767) is purely automated and just does the automated pre-commit fixes. I'll merge these in without squashing, so that the latter can be added to |
|
Nice, I'm always in favor of splitting it that way :) |
Checklist