Allow for assertions against intentional non-match #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-Sommers
commented
May 31, 2022
Will-Sommers
commented
May 31, 2022
Will-Sommers
commented
May 31, 2022
pokey
reviewed
May 31, 2022
…ursorless into wsommers/error-recorder
8 tasks
pokey
reviewed
Jun 3, 2022
src/testUtil/TestCase.ts
Outdated
| /** The final state after a command is issued. Undefined if we are testing a non-match(error) case. */ | ||
| finalState?: TestCaseSnapshot; | ||
| /** Used to assert if an error has been thrown. */ | ||
| errorName?: ThrownError; |
pokey
reviewed
Jun 3, 2022
src/testUtil/TestCaseRecorder.ts
Outdated
| @@ -248,7 +257,6 @@ export class TestCaseRecorder { | |||
| // command for a navigation map test | |||
| return; | |||
| } | |||
|
|
|||
pokey
previously approved these changes
Jun 3, 2022
pokey
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the ability to capture errors and non-matches from issued commands in the integration tests.
Why?
I wasn't able to do this as part of the TS-Scheme query PR and so added unit tests. I think it would be nice to have both. Non-matches help describe a complete spec of how expected behavior and unexpected behavior should be handled.
How?
finalStateinstead recorderrorReturnedas a booleanerrorReturnedis present on the fixture, ensure we throwTodo
errorReturnedricher? I don't want to assert on an error message but I wonder if there is information that we can record to make the test cases more valuable.