Fix positional inference #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Jun 21, 2022
| mark: {type: decoratedSymbol, symbolColor: default, character: w} | ||
| modifiers: | ||
| - {type: position, position: end} | ||
| - {type: toRawSelection} |
There was a problem hiding this comment.
Note that we add "just" here to break inference chain, because we actually had a bug where we weren't doing inference for subtoken modifiers that had a position, even though we should have been
| @@ -0,0 +1,62 @@ | |||
| languageId: plaintext | |||
There was a problem hiding this comment.
This test is the punchline: even though we have a modifier on the second destination target, we now infer "after" from the first destination target. Before, we would have stopped doing inference because it has a modifier "block"; now we handle position inference and non-positional inference independently, which was what we did before #672
AndreasArvidsson
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates inference so that we handle positional modifiers and non-positional modifiers separately, the way we did before #672. This way with the command
"bring air after line bat and block cap", we infer"bring air after line bat and *after* block cap", as desired, just as we used to do before #672Checklist