Leading/trailing infers token on empty range #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You seem to have pulled in my whole cheatsheet PR here 😅 |
AndreasArvidsson
force-pushed
the
leadingTrailingAsToken
branch
from
575401f to
9fc6923
Compare
|
Whoops. Fixed now. |
pokey
reviewed
Jul 6, 2022
AndreasArvidsson
commented
Jul 7, 2022
| @@ -4,17 +4,21 @@ import { ProcessedTargetsContext } from "../../typings/Types"; | |||
| import { isReversed } from "../../util/selectionUtils"; | |||
| import { MarkStage } from "../PipelineStages.types"; | |||
| import WeakTarget from "../targets/WeakTarget"; | |||
There was a problem hiding this comment.
I tried replacing these lines with import { TokenTarget, WeakTarget } from "../targets"; but that gives me the following error on extension activation: Activating extension 'pokey.cursorless' failed: Class extends value undefined is not a constructor or null.. I tried replacing all references to targets to go through the target/index file but no go.
There was a problem hiding this comment.
Huh. I can take a look in a follow-up. I wonder if we need to do the same trick for our stages
for more information, see https://pre-commit.ci
|
@pokey Do you know what the failed checks are about? |
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"chuck trailing"with empty selection now worksFixes #835
Checklist