-
-
Notifications
You must be signed in to change notification settings - Fork 84
Add the generate-examples library #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3603202
to
c0e9532
Compare
Hi @SimeonC, just checking in on this one to see:
Thanks! Fwiw I resolved merge conflicts so make sure to pull if you start hacking again 😊 |
Hi @pokey. Sorry for the radio silence, had a 3-month performance refactor that sapped all my mental energy and time. That's over and finished and I was hoping to get back and figure this out a bit more at some point. For what's left, I think it's the following;
I may not have any bandwidth until next year due to Christmas leave (unless I get some time next week). I definitely wanted to finish this - if you guys want to take it over and finish it to get it on the website I don't mind, I'm not so attached to it to block you guys from getting the features out you want. |
Hi @SimeonC. No worries; just wanted to check in. We have other stuff to focus on at the moment, so wouldn't pick it up until next year anyway. Happy to leave it with you for the time being |
There is an issue here that the jest parser requires no file name extension in imports, but ts-node requires `.js` extension. Probably will need to change this to build then generate rather than ts-node (or spend ages messing with the configs)
b072615
to
070c870
Compare
for more information, see https://pre-commit.ci
I'm still alive!! 🤣 Finally found some time and realised that my old code was so bad that there was no way I wanted to figure out what was going on so I started again. |
Nice! Will have a look. Fwiw we're about to be on a proper |
Oh, sorry - must have accidentally deleted the line that said that this still needs work - a couple more evenings when I get the chance. Mostly wanted to say I am still trying to find time to get this done and haven't just gone silent and ghosted you all. |
ah ok cool lmk when you want me to take a look; i'm happy to give early feedback if helpful |
Ok we're now a pnpm monorepo. The Also note that you can now import from the cursorless codebase, which should make your life easier |
Re importing packages from the rest of Cursorless codebase, any package that doesn't have |
Need to update to be in the new NX repo format and correctly handle the newer formats for test fixtures which have changed since this was written
@SimeonC lives! 😄 Good to see you hacking again. A lot has changed in this repo since you last merged up 😅. Maybe worth dropping into a meet-up to discuss? Note that we now have a spoken form generator that you could just use, but not sure it's necessary anymore as all of the spoken forms in our test cases have now been canonicalised, so I think you could just use the spoken form from the test case |
😆 Yea, I finally found some time. I've just been hacking away at the generation part and I can go figure out how to update everything to fit the updates. |
Fwiw we've also started just upgrading text fixture command payloads on the fly if we need the latest, so you should be able to do that to have your code work on legacy test fixtures. |
wip: Delete workspace.json for cherry-pick - git cherry pick 070c870 - Delete cursorless-nx/workspace.json Add the package and initial working There is an issue here that the jest parser requires no file name extension in imports, but ts-node requires `.js` extension. Probably will need to change this to build then generate rather than ts-node (or spend ages messing with the configs) [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci All working with tests Need to update to be in the new NX repo format and correctly handle the newer formats for test fixtures which have changed since this was written
wip: Delete workspace.json for cherry-pick - git cherry pick 070c870 - Delete cursorless-nx/workspace.json Add the package and initial working There is an issue here that the jest parser requires no file name extension in imports, but ts-node requires `.js` extension. Probably will need to change this to build then generate rather than ts-node (or spend ages messing with the configs) [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci All working with tests Need to update to be in the new NX repo format and correctly handle the newer formats for test fixtures which have changed since this was written
Have issues with the selections not quite being generated and inserted correctly (recursive selections are kinda hard).
Current output of the buildDictionary script is being manually ported into https://codepen.io/SimeonC/pen/gOeBJLr