Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Made LogRecordData keys parametric, rather than being restricted to Symbols #5

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

curtd
Copy link
Owner

@curtd curtd commented Apr 23, 2024

LogRecordData is now backed by a Dictionaries.Dictionary

feat: Added string interning

feat: Added add_record_data! method

…ted to `Symbol`s.

`LogRecordData` is now backed by a `Dictionaries.Dictionary`

feat: Added string interning

feat: Added `add_record_data!` method
@coveralls
Copy link

coveralls commented Apr 23, 2024

Pull Request Test Coverage Report for Build 8793110048

Details

  • 20 of 29 (68.97%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.9%) to 79.091%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/records.jl 19 28 67.86%
Files with Coverage Reduction New Missed Lines %
src/levels.jl 4 56.0%
Totals Coverage Status
Change from base Build 7732844627: -3.9%
Covered Lines: 87
Relevant Lines: 110

💛 - Coveralls

@curtd curtd merged commit c5f7cb1 into main Apr 23, 2024
5 checks passed
@curtd curtd deleted the expand_log_record_data_keys branch April 23, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants