feat: add nested json object support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for integration with i18n providers that offer an API to fetch your resources. Currently, only downloading zip files is supported
3 tasks
This was referenced Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for nested json objects to be translated easily. The way it works is by reading the file as string, doing some (very ugly) JSON magic and storing all keys and values accordingly.
I'm fairly sure this has some bugs and could be improved upon but it's the sanest solution I can think of without a complete rewrite where everything is a class.
For testing purposes, this also adds a dummy Tolgee integration (since Tolgee returns a zip file with JSON translations in their API). This needs some more work to be consolidated into a plugin however.
Closes #11