Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing dependencies takes much longer during builds #73

Closed
sttic opened this issue Nov 8, 2020 · 1 comment · Fixed by #74
Closed

Installing dependencies takes much longer during builds #73

sttic opened this issue Nov 8, 2020 · 1 comment · Fixed by #74
Assignees
Labels
bug Something isn't working

Comments

@sttic
Copy link
Contributor

sttic commented Nov 8, 2020

Installing dependencies takes much longer during builds.

See https://github.com/cusec/2021/runs/1366985806?check_suite_focus=true versus https://github.com/cusec/2021/runs/1344483283?check_suite_focus=true on Install Dependencies step (3m 35s and 20s respectively).

The extra time seems to be from falling back to source compile due to grpc pre-built binaries not being found.

> grpc@1.24.2 install /home/runner/work/2021/2021/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using request for node-pre-gyp https download 
node-pre-gyp WARN Tried to download(404): https://node-precompiled-binaries.grpc.io/grpc/v1.24.2/node-v83-linux-x64-glibc.tar.gz 
node-pre-gyp WARN Pre-built binaries not found for grpc@1.24.2 and node@14.15.0 (node-v83 ABI, glibc) (falling back to source compile with node-gyp) 
make: Entering directory '/home/runner/work/2021/2021/node_modules/grpc/build'

Potential solutions:

@sttic sttic added the bug Something isn't working label Nov 8, 2020
@sttic sttic self-assigned this Nov 8, 2020
sttic added a commit that referenced this issue Nov 8, 2020
`npm update` and `npm i firebase@latest`

refs: #73
sttic added a commit that referenced this issue Nov 10, 2020
Node 12 is recommended for @grpc/grpc-js.

refs: #73
@sttic
Copy link
Contributor Author

sttic commented Nov 10, 2020

Currently our builds uses the Ubuntu 18.04 environment provided with GitHub actions, which recently switched the default version of Node.JS to 14.x from 12.x. See:

The version switch caused these compatibility issues with @grpc/grpc-js (which recommends using Node 12). This explains why the CI suddenly started taking longer during npm ci dependency installation on the grpc step.

From my testing on my machine, Node 14 is where the issues start with the dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant