-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create visual editors for decluttering cards and templates. #78
base: master
Are you sure you want to change the base?
Conversation
The new 'custom:decluttering-template' card declares a template. It can be placed in any view of the dashboard and it is only visible in edit mode. Use the visual editor to conveniently create a template, configure the card or element, set variables with their default values, and preview the results. The existing 'custom:decluttering-card' card now searches for templates declared by 'custom:decluttering-template' cards in addition to those in the traditional decluttering_templates dashboard configuration. Use the visual editor to conveniently pick an existing template defined elsewhere, set variables, and preview the results. Fixed possible race conditions when cards are loaded and streamlined the logic. Restored previously set styles when element styles are modified. The element styling behavior is curiously undocumented...?
Represent each type as an abstract thing instead of pretending they are all cards. Choose the correct editor for each type (when one is available). Decluttering cards can now be safely embedded within entities cards as entity row and within picture-elements cards as elements.
Maintainers, can this be merged? It adds more functionality and also fixes #80, making this compatible with the new sections view type (just have to set the layout size on the template card)! |
@j9brown - This is awesome and exactly what’s needed. I hope the original author picks up on this and merges it soon. I can’t wait to try it out. PS: The devil’s advocate in me says “stencil” is a better name to use for the templates (Only because the HA team haven’t worked out the difference that decluttering-card brings to the table and it’ll be less confusing to use in discussion) :-) |
I'm glad you like it. I'm somewhat tempted to hard fork the project and publish a new version under a different name and I'd like to contact the original author before I do that. There are a bunch of changes needed to support new features in Home Assistant 2024.8, so expect to see those in my fork once I find some free time. That said, I do think that this "stencil" abstraction would be better off implemented directly within Home Assistant. It could also be considered a "blueprint" for cards and badges and other dashboard objects. |
@j9brown - Hi Jeff! Thanks for the response. Yeah, it’s a bit awkward not getting a response yet. Hopefully the author is okay and just busy. I believe the HASS agent integration had a similar situation crop up. As long as the release is respectfully done as a fork/variant then I’m sure the author will understand. A little free field-testing and feedback prior to a merge might be useful to the author too. If you do a fork, you’re guaranteed one visitor. I have enough custom cards to keep me busy in other ways. The decluttering card helped so much at keeping them neatly (and DRY-ly) in line :-). As for “stencil”, yeah, it’s not a strong advocacy thing :-), it’s just a thought. I’ve always felt decluttering card’s methods are just more KISS in nature. It’s also got elements of “boilerplate” now I come to think of it :-). Anyway, I’d better leave you to it. I’ve yet to read up on the August beta. regards and best wishes, Hammy |
I'll review that asap but not before mid-august |
Just tested out your fork and that is really sweet, great job. |
It seems that editMode was recently renamed to preview in the front end: home-assistant/frontend#21065 Rearranged the logic to toggle the hidden state to track the state of preview as it changes.
Tested this out and I like the concept of HA Version details: |
Oh that’s weird. I haven’t observed this behavior before. What cards are you putting into the template? Anything interesting in the logs? |
How strange! I'm sorry, I'm unable to reproduce this issue. I'm on the same version of Home Assistant so what browser are you using? I'm on Chrome. |
Might fix an issue with the template editor reported by a user.
@iceboundflame I've uploaded a new version 1.0.4 with an attempt to fix the issue by treating the incoming config object as immutable. I don't know why I can't reproduce it myself though and perhaps your browser is being more strict than mine. Please let me know if it helps! |
Thanks! Could you please post a compiled .js so I can test? 1.0.4 doesn't download via HACS and I can't find the .js. |
I've already posted the release. You might need to ask HACS to update the repository information. https://github.com/j9brown/decluttering-card/releases |
Just installed and it's working great now. Thank you, this is awesome! |
Hey @j9brown , is it possible to use your fork instead of the original package in HACS? I desperately need this and it's a shame it's not picked up here 😢 |
@jenseo Yes. First delete the original decluttering card within HACS if you have it already installed (don’t worry, you won’t lose any of your configuration and you can always go back). Then select the Custom Repositories menu item in HACS. Add my repository url https://github.com/j9brown/decluttering-card and set the type to “dashboard”. Once HACS fetches the contents, you should find decluttering card in the list of new items and can install it. My fork is backwards compatible so everything should work as before and you’ll also be able to use the new features. Details in the README.md. |
Works a charm, thanks a lot! 🙏 |
The new 'custom:decluttering-template' card declares a template. It can be placed in any view of the dashboard and it is only visible in edit mode. Use the visual editor to conveniently create a template, configure the card or element, set variables with their default values, and preview the results.
The existing 'custom:decluttering-card' card now searches for templates declared by 'custom:decluttering-template' cards in addition to those in the traditional decluttering_templates dashboard configuration. Use the visual editor to conveniently pick an existing template defined elsewhere, set variables, and preview the results.
Fixed possible race conditions when cards are loaded and streamlined the logic.
Restored previously set styles when element styles are modified. The element styling behavior is curiously undocumented...?