Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create script to download and then execute local binary tools #1
feat: create script to download and then execute local binary tools #1
Changes from all commits
83fa76e
b037067
c11c9d6
4d7ad88
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the strategy if this network call fails/times out and it doesn't return in success? should we have exception handling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this tool is only used as an internal tool at the moment and I believe that network request errors would be rare, I decided to put in less error handling into the tool, such as this scenario.
Therefore, at this time, if a network connection fails the tool will throw an exception and display the stacktrace in the terminal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this doesn't hurt us while working with CI, I honestly hate CI failing us because of some issues and then coming back to it and fixing it. But yeah not a blocker at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good point. I also want the CI to be stable while using this tool.
I see it being a rare occurrence for the CI to encounter failures for this line of code. Especially because the CI running on GitHub servers is downloading .zip files from GitHub, even more rare.
If you have any scenarios that you can think of on the CI that would make this script fail often, please share it as I would consider that a bug.