feat: add macOS x64 binaries to deployment #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levibostian
commented
Jan 10, 2024
| @@ -13,7 +13,7 @@ jobs: | |||
| run: deno test --allow-all # provide all permissions to the test script because it modifies file system to prepare for e2e tests. | |||
|
|
|||
| test-script-compiles-and-runs: | |||
| runs-on: ubuntu-latest | |||
| runs-on: macos-latest | |||
There was a problem hiding this comment.
I made this change because I saw running automated tests on the binny CI failed.
Even more proof that binny running swiftlint just doesn't work on Linux, haha!
Shahroz16
approved these changes
Jan 10, 2024
ami-aman
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, our iOS SDK CI server runs binny on Linux OS instead of macOS. I wanted to try to make the iOS SDK CI run on Linux instead of macOS because Linux is faster, but it doesn't work. I believe this is because the tools that binny executes (lint, formatter) are iOS tools and not may work on Linux.
To try and fix our iOS SDK CI, I ran an experiment of seeing if we run binny on macOS machines instead of Linux, it would fix the issue. It did fix it!
This PR makes binny make macOS x64 builds instead of just m1 builds. These new mac builds will be used by the iOS SDK's CI server.
After this PR is merged, another PR will be made on iOS SDK to start running binny on macOS.