Add analytics global key #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunofgs
force-pushed
the
add-analytics-global-key
branch
from
28910d0 to
4a11107
Compare
nunofgs
commented
Jan 30, 2025
.mise.toml
Outdated
| @@ -0,0 +1,5 @@ | |||
| [env] | |||
| NODE_OPTIONS = "--openssl-legacy-provider" | |||
There was a problem hiding this comment.
This is unrelated to this PR but needed to build the browser dist by running npm run build. I can remove it from this PR if the reviewer prefers.
nunofgs
commented
Jan 30, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
There are lots of seemingly unrelated changes. This PR is simply the result of:
$ git cherry-pick 7f4232cbdb60a4475c565e5d262b25182e47baf4
$ git cherry-pick 5c1511fe1e1d1df94967623b29ec12ffe770aacf
And the fixing merge conflicts.
nunofgs
changed the base branch from
main
to
allow-localhost-urls-for-analytics-js
nunofgs
force-pushed
the
add-analytics-global-key
branch
from
4a11107 to
e4d7cdc
Compare
Base automatically changed from
allow-localhost-urls-for-analytics-js
to
main
January 31, 2025 15:03
jatinn
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull changes from: