Add some tracing #11102
Open
Add some tracing #11102
+185
−4,574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7e8b26e in 37 seconds
More details
- Looked at
430lines of code in23files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. packages/server/customer-os-neo4j-repository/repository/contact_read_repository.go:866
- Draft comment:
Unnecessary use offmt.Sprintffor thecyphervariable. It can be a simple string since no formatting is needed.
cypher := `MATCH (t:Tenant {active:true, name: $tenant})<-[:CONTACT_BELONGS_TO_TENANT]-(c:Contact)--(l:Location)
WHERE c.hide = false and l.locality IS NOT NULL AND l.locality <> '' RETURN distinct l.locality`
- Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_6yLI6jS7436OsVQQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 70db844 in 24 seconds
More details
- Looked at
267lines of code in6files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. packages/server/customer-os-api/mapper/calendar_mapper.go:10
- Draft comment:
The 'SourceOfTruth' field has been removed from the 'MapEntityToCalendar' function. Ensure this is intentional and won't affect the application's logic. - Reason this comment was not posted:
Confidence changes required:50%
The PR description is empty, but the changes seem to focus on removing the 'SourceOfTruth' field from various structs and functions. This change is consistent across multiple files, indicating a deliberate refactor. However, the PR title suggests adding tracing, which is not evident in the changes. The removal of 'SourceOfTruth' should be confirmed as intentional.
2. packages/server/customer-os-api/mapper/custom_field_mapper.go:22
- Draft comment:
The 'SourceOfTruth' field has been removed from the 'MapCustomFieldInputToEntity' function. Ensure this is intentional and won't affect the application's logic. - Reason this comment was not posted:
Confidence changes required:50%
The 'SourceOfTruth' field has been removed from the 'MapCustomFieldInputToEntity' function. This change is consistent with other parts of the PR, but it's important to confirm that this removal is intentional and won't affect the application's logic.
3. packages/server/customer-os-api/mapper/custom_field_mapper.go:35
- Draft comment:
The 'SourceOfTruth' field has been removed from the 'MapCustomFieldUpdateInputToEntity' function. Ensure this is intentional and won't affect the application's logic. - Reason this comment was not posted:
Confidence changes required:50%
The 'SourceOfTruth' field has been removed from the 'MapCustomFieldUpdateInputToEntity' function. This change is consistent with other parts of the PR, but it's important to confirm that this removal is intentional and won't affect the application's logic.
4. packages/server/customer-os-api/repository/custom_field_repository.go:80
- Draft comment:
The 'SourceOfTruth' field has been removed from the 'MergeCustomFieldInTx' function. Ensure this is intentional and won't affect the application's logic. - Reason this comment was not posted:
Confidence changes required:50%
The 'SourceOfTruth' field has been removed from the 'MergeCustomFieldInTx' function. This change is consistent with other parts of the PR, but it's important to confirm that this removal is intentional and won't affect the application's logic.
5. packages/server/customer-os-api/repository/custom_field_repository.go:250
- Draft comment:
The 'SourceOfTruth' field has been removed from the 'UpdateForContactInTx' function. Ensure this is intentional and won't affect the application's logic. - Reason this comment was not posted:
Confidence changes required:50%
The 'SourceOfTruth' field has been removed from the 'UpdateForContactInTx' function. This change is consistent with other parts of the PR, but it's important to confirm that this removal is intentional and won't affect the application's logic.
Workflow ID: wflow_LCtQukV8k0vZD4Tl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7eff5f1 in 41 seconds
More details
- Looked at
48lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. packages/server/customer-os-api/graphql/resolver/billing_profile.resolvers.go:16
- Draft comment:
The function is currently not implemented and contains a panic statement. Ensure to implement the functionality before deploying to production. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds new resolver functions that are currently not implemented. This is a placeholder code, and the panic statements indicate that the functionality is yet to be developed. This is not a bug but a part of the development process.
Workflow ID: wflow_CneFLtP9g3XNaXA7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2b43469 in 1 minute and 58 seconds
More details
- Looked at
4820lines of code in37files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. packages/server/customer-os-api/graphql/generated/generated.go:13273
- Draft comment:
ThesourceOfTruthfield has been marked as deprecated across multiple entities. Ensure that this deprecation is documented and communicated to all relevant stakeholders, as it may impact existing integrations or client applications. This change is also present in other parts of the codebase, such as inBillingProfile,Calendar,InteractionSession,InteractionEvent,Issue,Location,LogEntry,Meeting,Note,Opportunity,PageView,Social,TenantBillingProfile, andUser. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes thesourceOfTruthfield from multiple entities and marks it as deprecated. This change is consistent across various files, indicating a deliberate decision to phase out this field. However, the PR description does not provide context or reasoning for this deprecation, which could be useful for future reference.
Workflow ID: wflow_5uvzRHv3g7GNPMwI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on e8ac718 in 43 seconds
More details
- Looked at
124lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. packages/server/customer-os-api/test/grpc/events_platform/test_dial_factory.go:34
- Draft comment:
TheMockOrganizationServiceregistration has been removed. Ensure that no tests depend on this mock service, as it might lead to test failures. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_mLUVLGt5JP4uMWdY
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 66612c0 in 42 seconds
More details
- Looked at
31lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. packages/server/customer-os-neo4j-repository/test/neo4j_data_helper.go:363
- Draft comment:
The functionsCreateBillingProfileForOrganizationandCreateBillingProfilewere removed. Ensure these functions are not used elsewhere in the codebase to avoid runtime errors. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_Idme7YkLHnsz5nbX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Deprecates
sourceOfTruthin GraphQL schemas, removes billing profile functionality, and updates repositories and services accordingly.sourceOfTruthfield in multiple GraphQL schemas, includingattachment.graphqls,billing_profile.graphqls,calendar.graphqls, and others.billing_profile.graphqls.billing_profile_service.goandinit.go.organization_event_handlers.go.organization_service.goandgrpc_server.go.billing_profile.resolvers_it_test.go.mock_organization.go.BillingProfileWriteRepositoryfromrepositories.goandbilling_profile_write_repository.go.contact_read_repository.goto fix cypher query issues.workspace_write_repository.goto include tenant parameter inMergefunction.This description was created by
for 66612c0. It will automatically update as commits are pushed.