Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port handler-proxy (http-only) #71

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Conversation

maksimkim
Copy link
Contributor

Original issue: netty/netty#1133
Original PR: netty/netty#2817

Motivation:
There is no support for client socket connections via a proxy server in SpanNetty.

Modifications:

  • Add a new module 'handler-proxy'
  • Add ProxyHandler and its subclasses to support and HTTP(S) (no SOCKS by now) proxy connections
  • Add a full parameterized test for most scenarios

Result:
A user can make an outgoing connection via proxy servers with only trivial effort.

}

[Theory]
[MemberData(nameof(CreateTestItems))]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@cuteant
Copy link
Owner

cuteant commented Jul 20, 2021

@maksimkim Also, some test cases(in 'libuv/handler' module) failed on azure devops, can be ignored for now(pass locally on Windows/Ubuntu),we could fix them by #51

Copy link
Owner

@cuteant cuteant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cuteant cuteant merged commit 46f4abe into cuteant:main Jul 20, 2021
tomkerkhove pushed a commit to maksimkim/SpanNetty that referenced this pull request Feb 8, 2023
Port handler-proxy (http-only)
nimakamoosi pushed a commit to maksimkim/SpanNetty that referenced this pull request Feb 15, 2024
Port handler-proxy (http-only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants