-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port handler-proxy (http-only) #71
Conversation
} | ||
|
||
[Theory] | ||
[MemberData(nameof(CreateTestItems))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@maksimkim Also, some test cases(in 'libuv/handler' module) failed on azure devops, can be ignored for now(pass locally on Windows/Ubuntu),we could fix them by #51 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Port handler-proxy (http-only)
Port handler-proxy (http-only)
Original issue: netty/netty#1133
Original PR: netty/netty#2817
Motivation:
There is no support for client socket connections via a proxy server in SpanNetty.
Modifications:
Result:
A user can make an outgoing connection via proxy servers with only trivial effort.